I saw @mjbvz’s tweet showing a screen cap of turning on checking for an existing JS file where a Promise value had been misused multiple times throughout the file, and doing the fix-all to add missing awaits. The result was an await added at every use site of the Promise, when it could have been added at the initializer. Someone even pointed out that the resulting code had unnecessarily many awaits in it.

The original codefix operated under the assumption that if a symbol from a variable declaration is referenced more than once, we shouldn’t change its initializer, to avoid a situation where something like

const result = fetch(url);
result.json(); // Error because `result` is a Promise<Response>, not a Response
result.then(() => {}); // Fine

would turn into

const result = await fetch(url);
result.json(); // Fine
result.then(() => {}); // Error because `result` is a Response, not a Promise<Response>

However, the enabling of checking for existing JavaScript shows a great example of why a Promise might be referenced many times, but wrongly every time, in such a way that the initializer can be awaited.

This PR fixes that example, along with a couple other scenarios where we should have been offering a fix for a variable initializer but weren’t.