Parsing support for jsDocComments.#3291
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Why would file be undefined?
CyrusNajmabadi
added a commit
that referenced
this pull request
May 28, 2015
Parsing support for jsDocComments.
Contributor
|
I do not see any tests for error cases.. are these going to be added later? |
Contributor
There was a problem hiding this comment.
when is this set to true? debugging? can you put a comment.
Contributor
Author
There was a problem hiding this comment.
This has been removed. It was only for ascertaining what we could'nt handle on code in the wild.
Contributor
Author
|
Also, there are about 32 tests for the error cases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are the same code changes as in #2646. However, this only contains the changes necessary for parsing, and none of the binding/checking changes.
Those will be coming in later once we agree on an overall design for how we incorporate the type information from those elements.
In the meantime though, supporting parsing is simple and will enable nice features like classification/completion in js doc comments.