Skip to content

fix constructors for DateTimeFormat, NumberFormat#3281

Merged
mhegazy merged 1 commit into
microsoft:masterfrom
bavardage:bugfix/fix-constructors
May 27, 2015
Merged

fix constructors for DateTimeFormat, NumberFormat#3281
mhegazy merged 1 commit into
microsoft:masterfrom
bavardage:bugfix/fix-constructors

Conversation

@bavardage
Copy link
Copy Markdown
Contributor

they were incorrectly producing a Collator

they were incorrectly producing a Collator
@msftclas
Copy link
Copy Markdown

Hi @bavardage, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!

This seems like a small (but important) contribution, so no Contribution License Agreement is required at this point. Real humans will now evaluate your PR.

TTYL, MSBOT;

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 27, 2015

Fixes #1911.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 27, 2015

👍

@zhengbli can you take a look

@zhengbli
Copy link
Copy Markdown

Looks good to me.
However, how do we generate the intl.d.ts? We should change the script of that too to avoid reverting it back in the future.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 27, 2015

This is hand edited, and not generated.

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 27, 2015

thanks @bavardage !

mhegazy added a commit that referenced this pull request May 27, 2015
fix constructors for DateTimeFormat, NumberFormat
@mhegazy mhegazy merged commit 118d87c into microsoft:master May 27, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants