🤖 User test baselines have changed#32753
Closed
typescript-bot wants to merge 1 commit into
Closed
Conversation
sandersn
requested changes
Aug 7, 2019
Member
sandersn
left a comment
There was a problem hiding this comment.
Need to find out why a bunch of identifiers are suddenly giving reserved errors.
| lib/Page.js(536,15): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/Page.js(589,14): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/Page.js(890,19): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/PipeTransport.js(19,5): error TS1213: Identifier expected. 'implements' is a reserved word in strict mode. Class definitions are automatically in strict mode. |
Member
There was a problem hiding this comment.
not sure what changed to make this an error
| Standard output: | ||
| node_modules/@typescript-eslint/typescript-estree/dist/parser.d.ts(1,8): error TS1259: Module '"/prettier/prettier/node_modules/typescript/lib/typescript"' can only be default-imported using the 'esModuleInterop' flag | ||
| src/cli/util.js(60,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | ||
| src/cli/util.js(60,44): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number'. |
Member
There was a problem hiding this comment.
probably a change in @types/node.
| node_modules/content-disposition/index.js(27,5): error TS1212: Identifier expected. 'private' is a reserved word in strict mode. | ||
| node_modules/content-disposition/index.js(34,5): error TS1212: Identifier expected. 'private' is a reserved word in strict mode. | ||
| node_modules/content-disposition/index.js(42,5): error TS1212: Identifier expected. 'private' is a reserved word in strict mode. | ||
| node_modules/content-disposition/index.js(50,19): error TS1127: Invalid character. |
Member
There was a problem hiding this comment.
ha ha oh no it's the scanner. @weswigham we are now giving two errors:
/**
* RegExp to match quoted-pair in RFC 2616
*
* quoted-pair = "\" CHAR
* CHAR = <any US-ASCII character (octets 0 - 127)>
* @private
*/- On
"\" @private
Broken by #32716
| node_modules/lodash/template.js(71,10): error TS1003: Identifier expected. | ||
| node_modules/lodash/template.js(71,10): error TS8024: JSDoc '@param' tag has name '', but there is no parameter with that name. | ||
| node_modules/lodash/template.js(102,36): error TS1127: Invalid character. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh