Fix Cannot read property 'text' of undefined crash#32734
Merged
RyanCavanaugh merged 3 commits intoAug 19, 2019
Conversation
|
|
Contributor
Author
|
Sorry, I fixed my code. |
RyanCavanaugh
requested changes
Aug 16, 2019
| return [leftStr, rightStr]; | ||
| } | ||
|
|
||
| function hasNoContextSymbolvalueDeclaration(type: Type): boolean { |
Member
There was a problem hiding this comment.
This only operates on type.symbol, so can just take the symbol directly. Suggested name symbolValueDeclarationIsContextSensitive and invert the return value. Implementation then is just
return symbol && symbol.valueDeclaration && isExpression(symbol.valueDeclaration) && isContextSensitive(symbol.valueDeclaration);
Contributor
Author
There was a problem hiding this comment.
Thank you for the review. Since the behavior changes when the return value is inverted, I changed your suggestion a bit.
7e1d11b to
f2abea4
Compare
Member
|
Thanks! |
timsuchanek
pushed a commit
to timsuchanek/TypeScript
that referenced
this pull request
Sep 11, 2019
* Fix Cannot read property 'text' of undefined crash * fix condition for tsx * Rename and improve the method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first time for me to send this repository.
I tried to fix the crash bug.
Fixes #32358