Avoid compile on save when there is no emit impact#32688
Merged
Conversation
sheetalkamat
reviewed
Aug 5, 2019
sheetalkamat
reviewed
Aug 6, 2019
sheetalkamat
approved these changes
Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, if compile on save is triggered based on changes in a .d.ts file, it runs even though there will be no impact to the emitted JS.
Here, we avoid running compile on save in this scenario as long as there is no possible impact to emitted code. To ensure this, we continue to trigger compile on save if declaration emit is enabled, either through the
declarationoption or thecompositeoption.