Migrated decorator checks to call resolution#3249
Merged
Merged
Conversation
Closed
Member
There was a problem hiding this comment.
Just make this a CallExpression | Decorator cast.
Member
|
We should have a couple of funky little tests like this: type ClassDecoratableWhenTagged = (ts: TemplateStringsArray, ...blah: any[]) => ClassDecorator;
declare let tag: ClassDecoratableWhenTagged;
@tag `Implicit call resolution in call resolution makes me feel ${ "extremely" } dizzy.`
class C {
constructor() {
}
} |
Member
There was a problem hiding this comment.
Sorry, the part that I originally found "gross" was that this call was ever in the if in the first place, not your changes; now that you've moved the parameter out though, it's at least a lot cleaner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than checking assignability, I've instead added a
resolveDecoratorfunction which acts in a similar fashion toresolveTaggedTemplateExpressionandresolveCallExpression, and I resolve the decorator as a call.Unlike a regular call expression, a decorator would be resolved using a set of synthetic arguments based on the target being decorated. This is similar to how call resolution works for a
TaggedTemplateExpression, which injects a syntheticTemplateStringsArraytype as the first argument.I pulled out this synthetic argument from
checkApplicableSignatureand added it and the generation of synthetic arguments for decorators to agetSyntheticArgumentTypefunction.This fixes #3246, as well as some other cases where we were doing the wrong thing when checking decorators.