Fix completion lists for 'readonly' and 'const' keywords#32377
Merged
Conversation
|
|
DanielRosenwasser
approved these changes
Jul 12, 2019
sheetalkamat
requested changes
Jul 15, 2019
Contributor
Author
|
Thanks @sheetalkamat! Improved |
sheetalkamat
approved these changes
Jul 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #29658 and #29666
#29666:
Added
readonlykeyword to "Type Keywords" list. It caused one test to fail, which I had to fix. That test was failing because it relied on existing behavior, but was not testing this behavior.#29658:
Added new
TypeAssertionKeywordsfilter toKeywordCompletionFilters, which is resolved to type keyword +constkeyword.constkeyword is not valid type keyword, so I decided to have it in separate filter, instead of putting it into type keywords.Formatting
My autoformatter fixed some minor formatting errors. Hope it is OK to keep them in this PR :)