Watch generated file if it doesnt exist when trying to translate it to to source generated position#32147
Merged
Merged
Conversation
…o to source generated position
|
|
||
| /* @internal */ | ||
| addGeneratedFileWatch(generatedFile: string, sourceFile: string) { | ||
| if (this.compilerOptions.outFile || this.compilerOptions.out) { |
Member
There was a problem hiding this comment.
I'm not really understanding the connection between outFile/out and the single watcher vs. multi watcher scenario. Can you give me a little background?
Member
Author
There was a problem hiding this comment.
If options specify outFile or out there is going to be single generated file for all source files in the program. Otherwise 1:1 mapping between source and generated files
Member
There was a problem hiding this comment.
I was definitely reading this as outFile/outDir in my head, and was confused how it could apply to outDir—and the answer is it doesn’t. Makes sense now, thanks 🤦♂
orta
reviewed
Jun 28, 2019
Co-Authored-By: Orta <orta.therox+github@gmail.com>
andrewbranch
approved these changes
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue with d.ts files generated after project creation to be picked up.