Fix tuple and array comparisons during identity checking#32089
Merged
Conversation
Member
Author
|
@typescript-bot run dt |
Collaborator
|
Heya @weswigham, I've started to run the parallelized Definitely Typed test suite on this PR at 2b5fec4. You can monitor the build here. It should now contribute to this PR's status checks. |
Collaborator
|
Heya @weswigham, I've started to run the extended test suite on this PR at 2b5fec4. You can monitor the build here. It should now contribute to this PR's status checks. |
ahejlsberg
approved these changes
Jun 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31967
We cache
isTypeIdenticalToassuming it is reflexive. We had a bug where[number, ...number[]]compared withnumber[]returnedtrue, whilenumber[]compared with[number, ...number[]]returnedfalse(that is to say, the result was based on their assignability relationship and not their identity) - so whichever got run first got cached. With this change we now appropriately returnfalsein both cases.