🤖 User test baselines have changed#30937
Conversation
24f8823 to
0768134
Compare
sandersn
left a comment
There was a problem hiding this comment.
Could be an intended change or a bug. Haven't had time to bisect (or look over the recent changes).
| Exit Code: 1 | ||
| Standard output: | ||
| lib/Accessibility.js(118,15): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/Accessibility.js(310,7): error TS2322: Type 'string | number | boolean' is not assignable to type 'never'. |
There was a problem hiding this comment.
node[userStringProperty] = properties.get(userStringProperty) :
SerialisedAXNode[keyof SerialisedAXNode] <== number | string | booleanwhere
keyof SerialisedAXNode : string | number | boolean | SerialisedAXNode[]The difference is probably that now
SerialisedAXNode[keyof SerialisedAXNode] : neverThere was a problem hiding this comment.
Yeah, this is an intended result of #30769 - since there's no generic tying userStringProperty to the result of properties.get(userStringProperty), we don't know they you're assigning the value corresponding to the selected key to the correct key'd member. Unfortunately, you need to write a subtype of Map's type to do that (otherwise Map.get has no method type parameter to be generic on).
sandersn
left a comment
There was a problem hiding this comment.
So it sounds like we're good to merge then because this break isn't that bad.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh