ProjectService passing incorrect object to parseConfigFile()#3047
Conversation
The return signature of `readConfigFile()` changed in f8424d0 and the code using it in `ProjectService` was never updated to match. This lead to the language services attempting to parse an object that doesn't match what is expected and using the default compiler options instead of what is defined in `tsconfig.json`. Similarly, the return value of the closure in `getTSConfigFileInfo()` was never updated to match in both places it returns.
|
Hi @bryanforbes, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! TTYL, MSBOT; |
There was a problem hiding this comment.
how did that even compile?
There was a problem hiding this comment.
forwardJSONCall takes a function that returns any. so it is not going to complain regardless what we put in there :)
|
Thanks @bryanforbes! |
|
@bryanforbes I am just waiting on the CLA. Otherwise looks good to me. Thanks again. |
|
@mhegazy Do I need to sign a personal CLA, or will my employer's CLA cover me? |
|
@bryanforbes it depends if this is a personal contribution or in the course of your work. if it is later and you believe SitePen has a different agreement, then there is nothing you need to do, and I need to check with @msftclas. |
|
@bryanforbes just checked with @msftclas and they said each contributor needs a separate CLA. Sorry for the confusion on my part, I really do not understand any of this legal stuff :D |
|
@bryanforbes, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR. |
|
@mhegazy Don't worry about it. I get confused by it too. Let me know if there's anything else I need to do. |
ProjectService passing incorrect object to parseConfigFile()
|
Thanks! |
The return signature of
readConfigFile()changed in f8424d0 and the code using it inProjectServicewas never updated to match. This lead to the language services attempting to parse an object that doesn't match what is expected and using the default compiler options instead of what is defined intsconfig.json. Similarly, the return value of the closure ingetTSConfigFileInfo()was never updated to match in both places it returns.This contribution should be covered by SitePen's corporate CLA.