Use sha256 to hash file contents#29935
Merged
Merged
Conversation
sheetalkamat
approved these changes
Feb 15, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The security team is complaining because we're not allowed to use cryptographically-compromised hash functions for non-crypto purposes if those functions were ever used by other people for crypto purposes in the past. 🤷♂️
Benchmarks show this to be about 30% slower compared to MD5, but we're generally looking at about 8.7ms to SHA256 checker.ts vs 6.4ms for MD5, so the net effect on any program that fits in memory should be less than 30ms overall.
As a side note, generateDjb2Hash is 40 times slower than sha256 - if this is ever called in practice, we should probably make it faster.