Updated ES6 declarations for Promise, updated baselines#2982
Merged
Conversation
Contributor
There was a problem hiding this comment.
We have not done the "I" prefix before.
Contributor
Author
There was a problem hiding this comment.
According to the Promise/A+ specification, a "thenable" is any object with a callable "then". A "promise" is a "thenable" that conforms to the Promise/A+ specification. In the async functions prototype, I use the Thenable interface for type checking a thing that is not a promise.
I think a better interface name is PromiseLike, similar to our ArrayLike.
Fixes helpers in strict mode
rbuckton
added a commit
that referenced
this pull request
May 2, 2015
Updated ES6 declarations for Promise, updated baselines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated typings for Promise in ES6. Fixes #2934