Support email in author JSDoc tag#29717
Merged
sandersn merged 3 commits intoJul 3, 2019
Merged
Conversation
|
|
sandersn
requested changes
Feb 5, 2019
Member
sandersn
left a comment
There was a problem hiding this comment.
Some ideas for simplifying the code.
| const result = <JSDocAuthorTag>createNode(SyntaxKind.JSDocAuthorTag, start); | ||
| result.tagName = tagName; | ||
|
|
||
| const comment = tryParse(() => tryParseAuthorNameAndEmail()); |
Member
There was a problem hiding this comment.
Since you aren't putting the author address into a separate field, I think would be pretty simple to make this work without backtracking.
Contributor
Author
There was a problem hiding this comment.
I'm not sure about the best way to achieve that. I return the parsing back to parseTag in case there is no email address provided instead of taking over parsing for the tag in all cases.
7deee5d to
6e4f581
Compare
26dd3fa to
93bb0be
Compare
93bb0be to
08bd017
Compare
sandersn
approved these changes
Jul 3, 2019
|
Sad this is not in 3.5. 😢 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17244