Skip to content

Fix type reference dts emit failure#29695

Merged
rbuckton merged 2 commits into
masterfrom
fixDtsTypeReferenceEmit
Feb 4, 2019
Merged

Fix type reference dts emit failure#29695
rbuckton merged 2 commits into
masterfrom
fixDtsTypeReferenceEmit

Conversation

@rbuckton
Copy link
Copy Markdown
Contributor

@rbuckton rbuckton commented Feb 2, 2019

When we emit declaration files, we sometimes do not emit /// <reference type="" /> directives when the declaration file contains a symbol exposed by the type reference entry point file via a /// <reference path="" /> directive.

Fixes DefinitelyTyped/DefinitelyTyped#32720

@rbuckton rbuckton requested a review from weswigham February 2, 2019 00:11
@rbuckton
Copy link
Copy Markdown
Contributor Author

rbuckton commented Feb 2, 2019

@typescript-bot test this

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Feb 2, 2019

Heya @rbuckton, I've started to run the extended test suite on this PR at 4b84f56. You can monitor the build here. It should now contribute to this PR's status checks.

@rbuckton
Copy link
Copy Markdown
Contributor Author

rbuckton commented Feb 4, 2019

@typescript-bot test this

@typescript-bot
Copy link
Copy Markdown
Collaborator

typescript-bot commented Feb 4, 2019

Heya @rbuckton, I've started to run the extended test suite on this PR at 4756373. You can monitor the build here. It should now contribute to this PR's status checks.

@rbuckton rbuckton merged commit 5576227 into master Feb 4, 2019
@rbuckton rbuckton deleted the fixDtsTypeReferenceEmit branch February 4, 2019 21:03
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants