Get type definition at position#2966
Merged
Merged
Conversation
Member
There was a problem hiding this comment.
We should review for a common name with other LS teams.
Member
|
Let's get a test in for primitives: |
Member
|
Let's also get a test for goToType on a constructor (i.e. what happens if I have |
Member
|
Oh, and also a test for something with a type literal. |
Member
There was a problem hiding this comment.
Remove this and the above line
Contributor
Author
There was a problem hiding this comment.
I added it to match the /// GOTO Definition above
Member
|
Remove the line I mentioned and then 👍 |
mhegazy
added a commit
that referenced
this pull request
May 4, 2015
Get type definition at position
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation for goto type in the services and server layers.