🤖 User test baselines have changed#29560
Conversation
sandersn
left a comment
There was a problem hiding this comment.
All the changes except the antd one are from Pranav's fix for constructor function return type resolution and are good changes. Not sure yet about the antd one, but it's interfaces in d.ts files so I'm pretty sure it's not related. Let's not merge until we figure out antd though.
| node_modules/lodash/_cloneArrayBuffer.js(11,16): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature. | ||
| node_modules/lodash/_cloneBuffer.js(4,69): error TS2339: Property 'nodeType' does not exist on type '(buffer: any, isDeep?: boolean | undefined) => any'. | ||
| node_modules/lodash/_cloneBuffer.js(7,80): error TS2339: Property 'nodeType' does not exist on type '{ "../../../tests/cases/user/lodash/node_modules/lodash/_cloneBuffer": (buffer: any, isDeep?: boolean | undefined) => any; }'. | ||
| node_modules/lodash/_cloneBuffer.js(20,12): error TS2587: JSDoc type 'Buffer' circularly references itself. |
| node_modules/chrome-devtools-frontend/front_end/bindings/BreakpointManager.js(120,52): error TS2339: Property 'valuesArray' does not exist on type 'Multimap'. | ||
| node_modules/chrome-devtools-frontend/front_end/bindings/BreakpointManager.js(123,34): error TS2339: Property 'clear' does not exist on type 'Multimap'. | ||
| node_modules/chrome-devtools-frontend/front_end/bindings/BreakpointManager.js(153,34): error TS2339: Property 'deleteAll' does not exist on type 'Multimap'. | ||
| node_modules/chrome-devtools-frontend/front_end/bindings/BreakpointManager.js(97,56): error TS2345: Argument of type 'string' is not assignable to parameter of type 'K'. |
There was a problem hiding this comment.
looks like we're moving on to "constructor functions are not really classes" bugs now, because those are uninstantiated type variables.
| node_modules/chrome-devtools-frontend/front_end/source_frame/SourcesTextEditor.js(809,26): error TS2339: Property 'addLineClass' does not exist on type 'CodeMirror'. | ||
| node_modules/chrome-devtools-frontend/front_end/source_frame/SourcesTextEditor.js(821,33): error TS2339: Property 'getLine' does not exist on type 'CodeMirror'. | ||
| node_modules/chrome-devtools-frontend/front_end/source_frame/SourcesTextEditor.js(829,24): error TS2339: Property 'removeOverlay' does not exist on type 'CodeMirror'. | ||
| node_modules/chrome-devtools-frontend/front_end/source_frame/SourcesTextEditor.js(759,9): error TS1345: An expression of type 'void' cannot be tested for truthiness |
There was a problem hiding this comment.
this error is because Closure's externs.js format is not the d.ts that Typescript expects.
| node_modules/bluebird/js/release/using.js(78,20): error TS2339: Property 'doDispose' does not exist on type 'Disposer'. | ||
| node_modules/bluebird/js/release/using.js(97,23): error TS2339: Property 'data' does not exist on type 'FunctionDisposer'. | ||
| node_modules/bluebird/js/release/using.js(223,15): error TS2350: Only a void function can be called with the 'new' keyword. | ||
| node_modules/bluebird/js/release/util.js(200,32): error TS2339: Property 'foo' does not exist on type 'FakeConstructor'. |
There was a problem hiding this comment.
previously, we weren't using isJSConstructor to detect constructor functions, just this-prototype assignment. Now have an assigned prototype (FakeConstructor.prototype = {}) is enough.
| Exit Code: 1 | ||
| Standard output: | ||
| node_modules/antd/lib/tree-select/interface.d.ts(26,18): error TS2430: Interface 'TreeSelectProps' incorrectly extends interface 'AbstractSelectProps'. | ||
| Types of property 'getPopupContainer' are incompatible. |
There was a problem hiding this comment.
Pretty sure this change is unrelated.
There was a problem hiding this comment.
It's because of an incorrect change in antd which they have since fixed, but not yet shipped (I think.) Let's accept it for now and then update again when the new version is available.
|
@PranavSenthilnathan You might be interested to see how the user tests change when you merge a significant fix. |
sandersn
left a comment
There was a problem hiding this comment.
antd break is in the source.
| Exit Code: 1 | ||
| Standard output: | ||
| node_modules/antd/lib/tree-select/interface.d.ts(26,18): error TS2430: Interface 'TreeSelectProps' incorrectly extends interface 'AbstractSelectProps'. | ||
| Types of property 'getPopupContainer' are incompatible. |
There was a problem hiding this comment.
It's because of an incorrect change in antd which they have since fixed, but not yet shipped (I think.) Let's accept it for now and then update again when the new version is available.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh