Qualified name param tag error#29352
Merged
Merged
Conversation
added 5 commits
January 9, 2019 15:52
…op level param name
|
|
||
| ==== tests/cases/conformance/jsdoc/paramTagNestedWithoutTopLevelObject.js (1 errors) ==== | ||
| /** | ||
| * @param {number} xyz.p |
Member
There was a problem hiding this comment.
can you also add test case for xyz.bar.p when there is
xyz.barbut noxyzxyzbut noxyz.bar- no
xyzorxyz.bar
sandersn
requested changes
Jan 10, 2019
Member
sandersn
left a comment
There was a problem hiding this comment.
Looks good but missing baselines for tests 2 and 3.
| @@ -0,0 +1,12 @@ | |||
| // @noEmit: true | |||
Member
There was a problem hiding this comment.
looks like 2 and 3 are missing their baselines
| @@ -0,0 +1,12 @@ | |||
| tests/cases/conformance/jsdoc/paramTagNestedWithoutTopLevelObject4.js(2,20): error TS8032: Qualified name 'xyz.bar.p' is not allowed without a leading '@param {object} xyz.bar'. | |||
Member
There was a problem hiding this comment.
I like this error because, although it's not correct, (1) pasting in the suggested line leads to another error with the correct fix and (2) I can't think of a good way to word the fact that you actually need two more lines.
sandersn
approved these changes
Jan 10, 2019
sheetalkamat
approved these changes
Jan 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27010 by displaying a better error message.
The following code
generates the following error message:
Qualified name 'xyz.p' is not allowed without a leading '@param {object} xyz'.