Better error message for invalid bigint literals ending with n#28896
Merged
DanielRosenwasser merged 2 commits intoDec 18, 2018
Merged
Conversation
Helps with the cases of decimals and exponentials, though not with numbers incorrectly starting with `0`. Fixes microsoft#28887.
JoshuaKGoldberg
commented
Dec 7, 2018
JoshuaKGoldberg
commented
Dec 18, 2018
sheetalkamat
approved these changes
Dec 18, 2018
| @@ -67,15 +69,19 @@ tests/cases/compiler/identifierStartAfterNumericLiteral.ts(26,5): error TS2304: | |||
| ~~ | |||
| !!! error TS1351: An identifier or keyword cannot immediately follow a numeric literal. | |||
| 3en[null] | |||
Member
There was a problem hiding this comment.
This is a great test case.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps with the cases of decimals and exponentials, though not with numbers incorrectly starting with
0.Fixes #28887.