Error when destructuring private property in a parameter#28562
Merged
2 commits merged intoNov 16, 2018
Merged
Conversation
sheetalkamat
approved these changes
Nov 16, 2018
This was referenced Nov 17, 2018
|
Don't you want to add a test for this one? |
Author
|
See the bottom of |
|
Oh, I'm sorry, I was going to comment in #26760, so there would be nested destructuring context. I thought we could add something like this to let nested = { k };
let {k: {priv: an, prot: bn, privateMethod: pmn}} = nested; // errorWhat do you think? |
Author
|
PRs accepted. 👍 |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the check was only done if
parent.initializerexisted, which meant it worked for variable declarations but not for parameters.