Expose aggregate file sizes in FileStats#28559
Merged
Merged
Conversation
Since it's for telemetry, it prefers to return a stale value rather than triggering file IO (though it will load the file if not even a stale value is available).
We're not sure that file counts are a good proxy for project size and this will give us more direct insight.
Member
Author
|
FYI @minestarks |
Member
Author
|
@DanielRosenwasser I'd be really happy to have this in 3.2 (after I fix the tests, of course). |
sheetalkamat
requested changes
Nov 16, 2018
sheetalkamat
approved these changes
Nov 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We're not sure that file counts are a good proxy for project size and this will give us more direct insight.