Updated emit for __decorator and __metadata helpers#2853
Merged
Conversation
Contributor
|
👍 This needs to go into release-1.5 and then ported to master. |
rbuckton
added a commit
that referenced
this pull request
Apr 21, 2015
Updated emit for __decorator and __metadata helpers
Contributor
Author
|
This is now in both master and release-1.5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes part of #2811, by deferring the execution of calls to
Reflect.decorateandReflect.metadatato when the helper is called rather than when it is defined.This PR will not cover other concerns related to
thisbinding, and does not attempt to reorder or move the position of any helper functions that we may emit.