When contextual type doesnt find property in unit type, use the index signature from unit type(fix the incorrectly used union type to get the signature)#27952
Merged
Conversation
…om unit type(fix the incorrectly used union type to get the signature) Fixes #27949
weswigham
approved these changes
Oct 17, 2018
Member
weswigham
left a comment
There was a problem hiding this comment.
The CI failures look like lint changes, but seem unrelated? Know why? Did the better contextual typing somehow affect the types of the things being asserted in a positive way?
Member
|
Build failure seems unrelated; it's happening elsewhere. I'm guessing tslint updated or something? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #27949