🤖 User test baselines have changed#27941
Conversation
sandersn
left a comment
There was a problem hiding this comment.
Not sure whether to merge this. I think I will try to update our test code instead.
| @@ -0,0 +1,20 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| index.tsx(33,21): error TS2339: Property 'email' does not exist on type 'object'. | |||
There was a problem hiding this comment.
We should probably update the example as a result. It looks like a lot fewer anys are being inferred.
There was a problem hiding this comment.
@weswigham, this is a failure of inference; when I explicitly provide a type argument to <Formik<...> ... everything is fine. Maybe this is a result of JSX call resolution? Mind taking a look?
There was a problem hiding this comment.
I've got a fix up: #27953
Previously JSX did some jank with using apparent types when they shouldn't have which is probably what hid the issue.
| @@ -0,0 +1,20 @@ | |||
| Exit Code: 1 | |||
| Standard output: | |||
| index.tsx(33,21): error TS2339: Property 'email' does not exist on type 'object'. | |||
There was a problem hiding this comment.
@weswigham, this is a failure of inference; when I explicitly provide a type argument to <Formik<...> ... everything is fine. Maybe this is a result of JSX call resolution? Mind taking a look?
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @RyanCavanaugh