Skip to content

Fix circular mapped type instantiations for arrays and tuples #27911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ahejlsberg merged 8 commits into from
Oct 15, 2018
Merged

Fix circular mapped type instantiations for arrays and tuples #27911

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d069875
Allow discriminant property to contain some non-unit types
ahejlsberg Oct 10, 2018
c110f57
Discriminant must include at least one unit type and no instantiable …
ahejlsberg Oct 10, 2018
7737cd5
Accept new baselines
ahejlsberg Oct 10, 2018
22907bf
Add tests
ahejlsberg Oct 10, 2018
6cdba6d
Accept new baselines
ahejlsberg Oct 10, 2018
709f5f2
Handle circular mapped type instantiations for arrays and tuples
ahejlsberg Oct 15, 2018
0c3221c
Add regression test
ahejlsberg Oct 15, 2018
3930525
Accept new baselines
ahejlsberg Oct 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add regression test
  • Loading branch information
@ahejlsberg
ahejlsberg committed Oct 15, 2018
commit 0c3221c2205f50ec3f0c069ec919f35b7aebfb5a
11 changes: 10 additions & 1 deletion tests/cases/conformance/types/mapped/recursiveMappedTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,13 @@ type Recurse1 = {

type Recurse2 = {
[K in keyof Recurse1]: Recurse1[K]
}
}

// Repro from #27881

export type Circular<T> = {[P in keyof T]: Circular<T>};
type tup = [number, number, number, number];

function foo(arg: Circular<tup>): tup {
return arg;
}