Enable --strictPropertyInitialization#27558
Merged
4 commits merged intoNov 17, 2018
Merged
Conversation
sheetalkamat
reviewed
Oct 4, 2018
| /* @internal */ | ||
| getCurrentProgram() { | ||
| return this.program; | ||
| return Debug.assertDefined(this.program); |
Member
There was a problem hiding this comment.
I don't think this is always defined? This can be undefined
sheetalkamat
reviewed
Oct 4, 2018
| private pendingProjectUpdates = createMap<Project>(); | ||
| /* @internal */ | ||
| pendingEnsureProjectForOpenFiles: boolean; | ||
| pendingEnsureProjectForOpenFiles: boolean | undefined; |
sheetalkamat
reviewed
Oct 4, 2018
|
|
||
| /*@internal*/ | ||
| canConfigFileJsonReportNoInputFiles: boolean; | ||
| canConfigFileJsonReportNoInputFiles: boolean | undefined; |
sheetalkamat
reviewed
Oct 4, 2018
|
|
||
| /*@internal*/ | ||
| cacheSourceFile: DocumentRegistrySourceFileCache; | ||
| cacheSourceFile!: DocumentRegistrySourceFileCache; // TODO: GH#18217 |
Member
There was a problem hiding this comment.
Should be instead DocumentRegistrySourceFileCache | undefined
sheetalkamat
reviewed
Oct 4, 2018
| if ("directoryExists" in this.shimHost) { | ||
| this.directoryExists = directoryName => this.shimHost.directoryExists(directoryName); | ||
| } | ||
| else { |
Author
There was a problem hiding this comment.
TypingResolutionHost requires directoryExists to be non-optional. It's likely that this.shimHost always contains directoryExists, so it always gets defined. Currently putting in these else blocks as a place to hold the TODO.
Author
|
@sheetalkamat Please re-review |
sheetalkamat
approved these changes
Oct 8, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
--strictPropertyInitializationintsconfig-base.jsonand updates declarations that were now errors.