In pickLongestCandidateSignature, instantiate using inferred type arguments#26646
Merged
1 commit merged intoAug 27, 2018
Merged
In pickLongestCandidateSignature, instantiate using inferred type arguments#266461 commit merged into
1 commit merged into
Conversation
sandersn
approved these changes
Aug 24, 2018
Member
sandersn
left a comment
There was a problem hiding this comment.
Looks fine barring one question: This code runs as part of error reporting, right? Why then do only fourslash tests change? It seems like we should have some test coverage of our errors for overloads.
Author
|
See #26426 (comment) -- for some reason the code only runs in services. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26639 and #26132