Skip to content

include leading non-ASCII horizontal whitespace#26465

Merged
RyanCavanaugh merged 1 commit into
masterfrom
unknown repository
Sep 5, 2018
Merged

include leading non-ASCII horizontal whitespace#26465
RyanCavanaugh merged 1 commit into
masterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Aug 15, 2018

Fixes #26464
The included test case is not passing with jake runtests tests=scannerNonAsciiHorizontalWhitespace. Any pointers on scanner test cases?

@msftclas
Copy link
Copy Markdown

msftclas commented Aug 15, 2018

CLA assistant check
All CLA requirements met.

@DanielRosenwasser
Copy link
Copy Markdown
Member

@rnathanday you need to add tests to tests/cases, then run jake runtests .... Then jake baseline-accept to see what the new results are.

@ghost
Copy link
Copy Markdown
Author

ghost commented Aug 25, 2018

@DanielRosenwasser thanks. Test case updated.

@RyanCavanaugh
Copy link
Copy Markdown
Member

RyanCavanaugh commented Sep 5, 2018

Going to spend the rest of the day wondering why there isn't a fivePerEmSpace in Unicode 🤔

Edit: That's what THIN SPACE is!

@RyanCavanaugh RyanCavanaugh merged commit 1e2fb9f into microsoft:master Sep 5, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants