Skip to content

Mapped types like Pick<T, K> should adopt property documentation from T.#26431

Merged
RyanCavanaugh merged 1 commit into
microsoft:masterfrom
mattmccutchen:issue-26430
Aug 16, 2018
Merged

Mapped types like Pick<T, K> should adopt property documentation from T.#26431
RyanCavanaugh merged 1 commit into
microsoft:masterfrom
mattmccutchen:issue-26430

Conversation

@mattmccutchen
Copy link
Copy Markdown
Contributor

@mattmccutchen mattmccutchen commented Aug 13, 2018

Fixes #26430.

How do I write a test for this?

@ghost
Copy link
Copy Markdown

ghost commented Aug 13, 2018

@mattmccutchen You could extend quickInfoMappedType.ts to include documentation comments. (Third parameter to quickInfoAt is for the documentation comment.)

@mattmccutchen
Copy link
Copy Markdown
Contributor Author

@Andy-MS Thanks! I added the test.

Copy link
Copy Markdown
Member

@RyanCavanaugh RyanCavanaugh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@RyanCavanaugh RyanCavanaugh merged commit 7a65825 into microsoft:master Aug 16, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants