Check large file size only for non ts files#26420
Merged
Merged
Conversation
ajafff
reviewed
Aug 14, 2018
| service.logger.info(`Skipped loading contents of large file ${fileName} for info ${this.info.fileName}: fileSize: ${fileSize}`); | ||
| this.info.containingProjects[0].projectService.sendLargeFileReferencedEvent(fileName, fileSize); | ||
| return ""; | ||
| // Only non typescript files have size limitation |
Contributor
There was a problem hiding this comment.
Doesn't that defeat the original purpose of detecting MPEG TS files?
Member
Author
There was a problem hiding this comment.
The purpose of change wasnt to detect mpeg file but to detect large json/js minified files. (eg. #24762 had minified js file which failed to parse/bind)
uniqueiniquity
approved these changes
Aug 16, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.