Add null check when querying for exported from a module#2642
Merged
Conversation
Member
There was a problem hiding this comment.
Do the check on the initial symbol; none of the others should ever be undefined, should they?
Contributor
Author
There was a problem hiding this comment.
we later on call visit(resolveExternalModuleName(node, (<ExportDeclaration>node).moduleSpecifier)); and that can be undefined if the module is empty. see my second test case.
Member
|
👍 |
mhegazy
added a commit
that referenced
this pull request
Apr 6, 2015
Add null check when querying for exported from a module
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2629