Merged
Conversation
sheetalkamat
approved these changes
Aug 13, 2018
RyanCavanaugh
approved these changes
Aug 13, 2018
weswigham
reviewed
Aug 14, 2018
Member
weswigham
left a comment
There was a problem hiding this comment.
Hm. So this has broken the nightly publish - probably because of the relative paths in, eg, the outDir of the cancellationToken tsconfig. Probably need to define it in that config, too (and also as ".").
Author
|
@weswigham That extends |
Member
|
Relative paths in the config are resolved relative to the config they were found in, though, right? |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25810
The problem was that we copy
src/services/tsconfig.jsontobuild/local/typescriptServices.tsconfig.json. But when compiling frombuilt/local, we'll get compile errors because the paths aren't inrootDirectorywhich defaults tooptions.configFilePath. These compile errors only happen when callinggetCommonSourceDirectory, explaining why the change toutilities.tsuncovers it.Note that when the change to
utilities.tsis made but not the change totsconfig-base.json, the error message is justError: ENOENT: no such file or directory, open 'built/local/typescriptServices.out.d.ts'with no compile errors shown; but I've verifeid that removing theprogramDiagnostics.addcall incheckSourceFilesBelongToPathmade it work again.