unittests/moduleResolution: actually assert in checkResolvedModule#26308
Merged
Conversation
this change uncovered a bug in testPreserveSymlinks which always silently failed
ajafff
commented
Aug 8, 2018
| return true; | ||
| } | ||
| return false; | ||
| function checkResolvedTypeDirective(actual: ResolvedTypeReferenceDirective, expected: ResolvedTypeReferenceDirective) { |
Contributor
Author
There was a problem hiding this comment.
This change is unrelated. The function is used in the same way as checkResolvedModule but is never called with undefined arguments. So this is just a drive-by simplification.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this change uncovered a bug in testPreserveSymlinks which always silently failed