Revise logic that computes the contextual type for a parameter#26244
Merged
Conversation
sandersn
approved these changes
Aug 7, 2018
Member
sandersn
left a comment
There was a problem hiding this comment.
Looks good, just curious about one thing.
|
|
||
| ////declare function foo(cb: (this: any, x: number, y: string, z: boolean) => void): void; | ||
| //// | ||
| ////foo(function(this, a, ...args) { |
Member
There was a problem hiding this comment.
Why write this is a fourslash test? Wouldn't the type baselines provide enough information to tell what the contextual type was?
Member
There was a problem hiding this comment.
The problem only occurred when we were hovering in to get the type -- type baselines work "top down" like the commandline compiler and do not observe the problematic behavior
RyanCavanaugh
approved these changes
Aug 7, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26099.