Block scoped classes#2623
Closed
vladima wants to merge 6 commits into
Closed
Conversation
Contributor
|
👍 |
Contributor
There was a problem hiding this comment.
I don't think the check for meaning & SymbolFlags.BlockScopedVariable is necessary. The only way for the parent to be a catch clause is if it is also a block scoped variable.
Contributor
There was a problem hiding this comment.
It has now switched from node to n. Please rename it back
Contributor
|
👍 |
1 similar comment
Contributor
|
👍 |
Merged
Contributor
Author
|
this PR is subsumed by #3380 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2595