Do not read files greater than maxFileSize which is currently 4mb#26169
Merged
Conversation
mhegazy
approved these changes
Aug 2, 2018
Contributor
|
Yes you send us an event, we can stop sending updates for these large files. Should we check the file size on our side before opening the file in the first place as well? |
Member
Author
|
@mjbvz Will create PR for event about large file in separate PR. Yes the large files shouldnt be sent to tsserver in open request at all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24762
@mjbvz
node_modules/solc/folder things will go bad because we arent reading contents from file but its passed by vscode.