improve completions for union type in type arguments#26140
Merged
Conversation
sheetalkamat
reviewed
Aug 2, 2018
|
|
||
|
|
||
| goTo.marker(); | ||
| // verify.completionListIsEmpty(); |
Member
There was a problem hiding this comment.
whats with the commented out code.? You want to be able to show completion even when b is not inserted in the string.
Contributor
Author
There was a problem hiding this comment.
Sorry, that is a mistake.
20696f4 to
23601a1
Compare
sheetalkamat
approved these changes
Aug 10, 2018
RyanCavanaugh
approved these changes
Aug 10, 2018
Member
|
@Kingwl good to merge? |
Contributor
Author
|
sure😉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25839