Skip to content

Instead of watching individual script infos, watch the node modules folder for script infos in node modules#26135

Merged
sheetalkamat merged 1 commit into
masterfrom
watchDirectoryOfNodeModulesScriptInfo
Sep 14, 2018
Merged

Instead of watching individual script infos, watch the node modules folder for script infos in node modules#26135
sheetalkamat merged 1 commit into
masterfrom
watchDirectoryOfNodeModulesScriptInfo

Conversation

@sheetalkamat
Copy link
Copy Markdown
Member

@sheetalkamat sheetalkamat commented Aug 1, 2018 •
edited
Loading

Newer version of #23596
Fixes #27039

@sheetalkamat sheetalkamat force-pushed the watchDirectoryOfNodeModulesScriptInfo branch from 76339de to 2c58d3d Compare August 1, 2018 23:31
@RyanCavanaugh
Copy link
Copy Markdown
Member

RyanCavanaugh commented Sep 5, 2018

@sheetalkamat what's the status on this one?

@sheetalkamat
Copy link
Copy Markdown
Member Author

sheetalkamat commented Sep 6, 2018

@RyanCavanaugh As per our offline sync, since this is just theorotical and there isnt any issue reported for this, we will wait for this.

@sheetalkamat sheetalkamat mentioned this pull request Sep 11, 2018
Closed
@sheetalkamat sheetalkamat force-pushed the watchDirectoryOfNodeModulesScriptInfo branch from 2c58d3d to e2edb69 Compare September 13, 2018 20:49
@sheetalkamat
Copy link
Copy Markdown
Member Author

sheetalkamat commented Sep 13, 2018

Thanks to @Andy-MS to see get this data for Linux. It is very minimal improvement and not much on Linux but helps a lot with windows when opening file from repro of #27039
With tsnext:

Info 952  [15:53:37.896] 	FileName: /home/andy/sample/DatingApp/DatingApp-SPA/src/main.ts ProjectRootPath: /home/andy/sample/DatingApp/DatingApp-SPA
Info 952  [15:53:37.896] 		Projects: /home/andy/sample/DatingApp/DatingApp-SPA/tsconfig.json
Perf 952  [15:53:37.896] 2::open: async elapsed time (in milliseconds) 4386.3848

With this PR:

Info 136  [15:56:17.95] Open files: 
Info 136  [15:56:17.95] 	FileName: /home/andy/sample/DatingApp/DatingApp-SPA/src/main.ts ProjectRootPath: /home/andy/sample/DatingApp/DatingApp-SPA
Info 136  [15:56:17.95] 		Projects: /home/andy/sample/DatingApp/DatingApp-SPA/tsconfig.json
Perf 136  [15:56:17.95] 2::open: async elapsed time (in milliseconds) 4359.4610

On Windows::
With tsnext:

Info 977  [16:32:37.785] 	FileName: c:/temp/DatingApp/DatingApp-SPA/src/main.ts ProjectRootPath: c:/temp/DatingApp/DatingApp-SPA
Info 977  [16:32:37.785] 		Projects: c:/temp/DatingApp/DatingApp-SPA/tsconfig.json
Perf 977  [16:32:37.785] 2::open: async elapsed time (in milliseconds) 14705.2836

With this PR:

Info 161  [16:38:10.222] -----------------------------------------------
Info 161  [16:38:10.222] Open files: 
Info 161  [16:38:10.222] 	FileName: c:/temp/DatingApp/DatingApp-SPA/src/main.ts ProjectRootPath: c:/temp/DatingApp/DatingApp-SPA
Info 161  [16:38:10.223] 		Projects: c:/temp/DatingApp/DatingApp-SPA/tsconfig.json
Perf 161  [16:38:10.223] 2::open: async elapsed time (in milliseconds) 9974.4252

@sheetalkamat
Copy link
Copy Markdown
Member Author

sheetalkamat commented Sep 13, 2018

@RyanCavanaugh It is ready to be reviewed and merged

@sheetalkamat sheetalkamat changed the title [WIP] Instead of watching individual script infos, watch the node modules folder for script infos in node modules Instead of watching individual script infos, watch the node modules folder for script infos in node modules Sep 13, 2018
@sheetalkamat sheetalkamat merged commit b563978 into master Sep 14, 2018
@sheetalkamat sheetalkamat deleted the watchDirectoryOfNodeModulesScriptInfo branch September 14, 2018 16:49
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@RyanCavanaugh RyanCavanaugh RyanCavanaugh approved these changes

Assignees

@sheetalkamat sheetalkamat

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sheetalkamat @RyanCavanaugh