Adding outlining for comments to allow collapsing in VS#2612
Merged
Conversation
added 11 commits
April 1, 2015 16:16
Fixing a typo in Coding Guidelines link https://github.com/Microsoft/TypeScript/wiki/Coding-guidelines (was missing an 'e')
… outlineComments
|
Hi @ahmad-farid, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Contributor
There was a problem hiding this comment.
use shorthand properties for hasTrailingNewLine and kind.
Contributor
|
Tests? |
Contributor
There was a problem hiding this comment.
only do this if this is a multiline comment. add a named-Comment for 'false'.
Only collapse multiline comment if it spans multiple lines.
added 8 commits
April 3, 2015 19:21
…s and debugging statements)
…into outlineCommentsFinal
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#698 Collapsable Comments in VS
While we're walking the file looking for collapsible nodes, check to see if a node has leading comments.
-- If block comments (/*) are available, create a new collapsible item through its span and add it to the elements to be collapsed.
-- For single line comments, create a collapsible item if two or more exist from the start of the first to the end of the last.