🤖 User test baselines have changed by typescript-bot · Pull Request #26088 · microsoft/TypeScript

typescript-bot · 2018-07-31T13:28:36Z

Please review the diff and merge if no changes are unexpected.
You can view the build log here.

sandersn

With @enum, chrome-devtools-frontend gets rid of over 600 lines of errors.

sandersn · 2018-07-31T16:06:06Z

@@ -1,55 +1,55 @@
 Exit Code: 1
 Standard output:
-node_modules/uglify-js/lib/ast.js(209,23): error TS2554: Expected 0 arguments, but got 1.


No real changes here, just some added lines.

sandersn · 2018-07-31T16:07:46Z

 lib/Page.js(394,22): error TS2503: Cannot find namespace 'Protocol'.
 lib/Page.js(407,15): error TS2503: Cannot find namespace 'Protocol'.
 lib/Page.js(731,19): error TS2503: Cannot find namespace 'Protocol'.
+lib/Page.js(928,3): error TS2322: Type '{ [x: string]: any; width: number; height: number; }' is not assignable to type 'string'.


Bad use of @enum:

/** @enum {string} */ Page.PaperFormats = { letter: { width: 8.5, height: 11 }, legal: { width: 8.5, height: 14 } }

Should be @enum {{width: number, heigh: number}}

sandersn · 2018-07-31T16:07:57Z

 Exit Code: 1
 Standard output:
-index.js(3,25): error TS2307: Cannot find module './package.json'.
+index.js(3,25): error TS2732: Cannot find module './package.json'. Consider using '--resolveJsonModule' to import module with '.json' extension


New, better error message.

sandersn · 2018-07-31T16:08:51Z

 node_modules/lodash/_baseUniq.js(62,15): error TS2554: Expected 2 arguments, but got 3.
 node_modules/lodash/_cloneArrayBuffer.js(11,16): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature.
 node_modules/lodash/_cloneBuffer.js(4,69): error TS2339: Property 'nodeType' does not exist on type '{}'.
-node_modules/lodash/_cloneBuffer.js(7,80): error TS2339: Property 'nodeType' does not exist on type 'NodeModule'.


We're resolving to the new module.exports symbol instead of NodeModule in @types/node.

sandersn · 2018-07-31T16:09:43Z

@@ -29,9 +29,7 @@ node_modules/chrome-devtools-frontend/front_end/Runtime.js(270,9): error TS2322:
  Type 'void' is not assignable to type 'undefined'.
 node_modules/chrome-devtools-frontend/front_end/Runtime.js(280,5): error TS2322: Type 'Promise<void>' is not assignable to type 'Promise<undefined>'.
 node_modules/chrome-devtools-frontend/front_end/Runtime.js(283,7): error TS2554: Expected 2-3 arguments, but got 1.
-node_modules/chrome-devtools-frontend/front_end/Runtime.js(398,24): error TS1138: Parameter declaration expected.


Result of better function() type parsing

sandersn · 2018-07-31T16:09:57Z

-node_modules/chrome-devtools-frontend/front_end/Runtime.js(398,24): error TS1138: Parameter declaration expected.
-node_modules/chrome-devtools-frontend/front_end/Runtime.js(398,24): error TS8024: JSDoc '@param' tag has name 'function', but there is no parameter with that name.
-node_modules/chrome-devtools-frontend/front_end/Runtime.js(527,49): error TS2352: Type 'Window' cannot be converted to type 'Function'.
+node_modules/chrome-devtools-frontend/front_end/Runtime.js(527,49): error TS2352: Conversion of type 'Window' to type 'Function' may be a mistake because neither type sufficiently overlaps with the other. If this was intentional, convert the expression to 'unknown' first.


More detailed error on type assertion.

sandersn · 2018-07-31T16:12:47Z

@@ -261,8 +259,6 @@ node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(189,
 node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(194,24): error TS2694: Namespace 'Protocol' has no exported member 'Animation'.
 node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(198,26): error TS2339: Property 'AnimationModel' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'.
 node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(202,25): error TS2694: Namespace 'Protocol' has no exported member 'Animation'.
-node_modules/chrome-devtools-frontend/front_end/animation/AnimationModel.js(290,51): error TS2694: Namespace 'Animation.AnimationModel.Animation' has no exported member 'Type'.


Type is an @enum, which is now recognised.

sandersn · 2018-07-31T16:18:02Z

@@ -347,7 +343,6 @@ node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(1
 node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(208,50): error TS2554: Expected 2 arguments, but got 1.
 node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(208,67): error TS2554: Expected 2 arguments, but got 1.
 node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(216,67): error TS2339: Property 'AnimationModel' does not exist on type '{ new (effect?: AnimationEffect, timeline?: AnimationTimeline): Animation; prototype: Animation; }'.
-node_modules/chrome-devtools-frontend/front_end/animation/AnimationTimeline.js(218,34): error TS2345: Argument of type 'number' is not assignable to parameter of type '{ [x: string]: any; WindowDocked: number; WindowUndocked: number; ScriptsBreakpointSet: number; TimelineStarted: number; ProfilesCPUProfileTaken: number; ProfilesHeapProfileTaken: number; AuditsStarted: number; ... 23 more ...; ShowedThirdPartyBadges: number; }'.


Host.UserMetrics.Action is now recognised as an @enum {number}, which allows numbers to be assigned to it.

sandersn · 2018-07-31T16:18:27Z

@@ -3045,8 +3035,6 @@ node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighth
 node_modules/chrome-devtools-frontend/front_end/audits2_worker/lighthouse/lighthouse-background.js(70848,34): error TS2304: Cannot find name 'fs'.
 node_modules/chrome-devtools-frontend/front_end/audits2_worker.js(5,11): error TS2339: Property 'Runtime' does not exist on type 'Window'.
 node_modules/chrome-devtools-frontend/front_end/audits2_worker.js(6,8): error TS2339: Property 'importScripts' does not exist on type 'Window'.
-node_modules/chrome-devtools-frontend/front_end/bindings/BlackboxManager.js(22,20): error TS1099: Type argument list cannot be empty.


better function() type parsing.

sandersn · 2018-07-31T16:21:17Z

-node_modules/chrome-devtools-frontend/front_end/bindings/CompilerScriptMapping.js(48,52): error TS2345: Argument of type 'string' is not assignable to parameter of type '{ [x: string]: any; Debugger: string; Formatter: string; Network: string; Snippets: string; FileSystem: string; ContentScripts: string; Service: string; }'.
-node_modules/chrome-devtools-frontend/front_end/bindings/CompilerScriptMapping.js(50,62): error TS2345: Argument of type 'string' is not assignable to parameter of type '{ [x: string]: any; Debugger: string; Formatter: string; Network: string; Snippets: string; FileSystem: string; ContentScripts: string; Service: string; }'.
-node_modules/chrome-devtools-frontend/front_end/bindings/CompilerScriptMapping.js(59,56): error TS2345: Argument of type 'string' is not assignable to parameter of type '{ [x: string]: any; Debugger: string; Formatter: string; Network: string; Snippets: string; FileSystem: string; ContentScripts: string; Service: string; }'.
+node_modules/chrome-devtools-frontend/front_end/bindings/CompilerScriptMapping.js(52,49): error TS2345: Argument of type 'ContentProviderBasedProject' is not assignable to parameter of type '{ [x: string]: any; workspace(): Workspace; id(): string; type(): string; isServiceProject(): boolean; displayName(): string; requestMetadata(uiSourceCode: UISourceCode): Promise<UISourceCodeMetadata>; ... 17 more ...; uiSourceCodes(): UISourceCode[]; }'.


Better errors because @enum is understoood. I think they are still wrong because ContentProviderBasedProject has @implements Project, which is the type that we are giving an assignability error for.

Update user baselines

2f9676d

typescript-bot requested review from mhegazy, sandersn and weswigham July 31, 2018 13:28

typescript-bot force-pushed the user-update-20180602 branch from 4feba79 to 2f9676d Compare July 31, 2018 13:28

sandersn approved these changes Jul 31, 2018

View reviewed changes

sandersn merged commit 6cd313b into microsoft:master Jul 31, 2018

microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🤖 User test baselines have changed#26088

🤖 User test baselines have changed#26088
sandersn merged 1 commit into
microsoft:masterfrom
typescript-bot:user-update-20180602

typescript-bot commented Jul 31, 2018

Uh oh!

sandersn left a comment

Uh oh!

sandersn Jul 31, 2018

Uh oh!

sandersn Jul 31, 2018

Uh oh!

sandersn Jul 31, 2018

Uh oh!

sandersn Jul 31, 2018

Uh oh!

sandersn Jul 31, 2018

Uh oh!

sandersn Jul 31, 2018

Uh oh!

sandersn Jul 31, 2018

Uh oh!

sandersn Jul 31, 2018

Uh oh!

sandersn Jul 31, 2018

Uh oh!

sandersn Jul 31, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

typescript-bot commented Jul 31, 2018

Uh oh!

sandersn left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants