Support signature help for contextual parameter type#26022
Merged
2 commits merged intoAug 6, 2018
Merged
Conversation
633ac18 to
2fd211d
Compare
sheetalkamat
reviewed
Aug 6, 2018
| } | ||
|
|
||
| function getArgumentOrParameterListInfo(node: Node, sourceFile: SourceFile): { readonly list: Node, readonly argumentIndex: number, readonly argumentCount: number, readonly argumentsSpan: TextSpan } | undefined { | ||
| const info = getArgumentOrParameterListAndIndex(node, sourceFile); |
Member
There was a problem hiding this comment.
Why not inline this function, as we would avoid unnecessary object creation and destructuring then.
Author
There was a problem hiding this comment.
It's called in two places -- inlining it twice would increase code size which could also hurt performance..
sheetalkamat
approved these changes
Aug 6, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25265