Skip to content

Port generated lib files#25944

Merged
mhegazy merged 2 commits into
masterfrom
portGeneratedLibFiles
Jul 31, 2018
Merged

Port generated lib files#25944
mhegazy merged 2 commits into
masterfrom
portGeneratedLibFiles

Conversation

@mhegazy
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy commented Jul 25, 2018 •
edited
Loading

Fixes #25547
Fixes #25509
Fixes #25468
Fixes #25176
Fixes #24869
Fixes #24633
Fixes #24205
Fixes #24119
Fixes #24084
Fixes #14703
Fixes #14701
Fixes #25968
Fixes #26038
Fixes #26074

This is one of our biggest changes to date. The library is partially generated from webidl files from the DOM specs, and as a result some vendor-specific types have been removed. here is the full list of removed types:

  • CanvasRenderingContext2D.mozImageSmoothingEnabled
  • CanvasRenderingContext2D.msFillRule
  • CanvasRenderingContext2D.oImageSmoothingEnabled
  • CanvasRenderingContext2D.webkitImageSmoothingEnabled
  • Document.caretRangeFromPoint
  • Document.createExpression
  • Document.createNSResolver
  • Document.execCommandShowHelp
  • Document.exitFullscreen
  • Document.exitPointerLock
  • Document.focus
  • Document.fullscreenElement
  • Document.fullscreenEnabled
  • Document.getSelection
  • Document.msCapsLockWarningOff
  • Document.msCSSOMElementFloatMetrics
  • Document.onvisibilitychange
  • Document.onwebkitfullscreenchange
  • Document.onwebkitfullscreenerror
  • Document.pointerLockElement
  • Document.queryCommandIndeterm
  • Document.URLUnencoded
  • Document.webkitCurrentFullScreenElement
  • Document.webkitFullscreenElement
  • Document.webkitFullscreenEnabled
  • Document.webkitIsFullScreen
  • Document.xmlEncoding
  • Document.xmlStandalone
  • Document.xmlVersion
  • DocumentType.entities
  • DocumentType.internalSubset
  • DocumentType.notations
  • DOML2DeprecatedSizeProperty
  • Element.msContentZoomFactor
  • Element.msGetUntransformedBounds
  • Element.msMatchesSelector
  • Element.msRegionOverflow
  • Element.msReleasePointerCapture
  • Element.msSetPointerCapture
  • Element.msZoomTo
  • Element.onwebkitfullscreenchange
  • Element.onwebkitfullscreenerror
  • Element.outerHTML
  • Element.webkitRequestFullScreen
  • Element.webkitRequestFullscreen
  • ElementCSSInlineStyle
  • ExtendableEventInit
  • ExtendableMessageEventInit
  • FetchEventInit
  • GenerateAssertionCallback
  • HTMLAnchorElement.Methods
  • HTMLAnchorElement.mimeType
  • HTMLAnchorElement.nameProp
  • HTMLAnchorElement.protocolLong
  • HTMLAnchorElement.urn
  • HTMLAreasCollection
  • HTMLHeadElement.profile
  • HTMLImageElement.msGetAsCastingSource
  • HTMLImageElement.msGetAsCastingSource
  • HTMLImageElement.msKeySystem
  • HTMLImageElement.msPlayToDisabled
  • HTMLImageElement.msPlayToDisabled
  • HTMLImageElement.msPlayToPreferredSourceUri
  • HTMLImageElement.msPlayToPreferredSourceUri
  • HTMLImageElement.msPlayToPrimary
  • HTMLImageElement.msPlayToPrimary
  • HTMLImageElement.msPlayToSource
  • HTMLImageElement.msPlayToSource
  • HTMLImageElement.x
  • HTMLImageElement.y
  • HTMLInputElement.webkitdirectory
  • HTMLLinkElement.import
  • HTMLMetaElement.charset
  • HTMLMetaElement.url
  • HTMLSourceElement.msKeySystem
  • HTMLStyleElement.disabled
  • HTMLSummaryElement
  • MediaQueryListListener
  • MSAccountInfo
  • MSAudioLocalClientEvent
  • MSAudioLocalClientEvent
  • MSAudioRecvPayload
  • MSAudioRecvSignal
  • MSAudioSendPayload
  • MSAudioSendSignal
  • MSConnectivity
  • MSCredentialFilter
  • MSCredentialParameters
  • MSCredentials
  • MSCredentialSpec
  • MSDCCEvent
  • MSDCCEventInit
  • MSDelay
  • MSDescription
  • MSDSHEvent
  • MSDSHEventInit
  • MSFIDOCredentialParameters
  • MSIceAddrType
  • MSIceType
  • MSIceWarningFlags
  • MSInboundPayload
  • MSIPAddressInfo
  • MSJitter
  • MSLocalClientEvent
  • MSLocalClientEventBase
  • MSNetwork
  • MSNetworkConnectivityInfo
  • MSNetworkInterfaceType
  • MSOutboundNetwork
  • MSOutboundPayload
  • MSPacketLoss
  • MSPayloadBase
  • MSPortRange
  • MSRelayAddress
  • MSSignatureParameters
  • MSStatsType
  • MSStreamReader
  • MSTransportDiagnosticsStats
  • MSUtilization
  • MSVideoPayload
  • MSVideoRecvPayload
  • MSVideoResolutionDistribution
  • MSVideoSendPayload
  • NotificationEventInit
  • PushEventInit
  • PushSubscriptionChangeInit
  • RTCIdentityAssertionResult
  • RTCIdentityProvider
  • RTCIdentityProviderDetails
  • RTCIdentityValidationResult
  • SVGElement.xmlbase
  • SVGGraphicsElement.farthestViewportElement
  • SVGGraphicsElement.getTransformToElement
  • SVGGraphicsElement.nearestViewportElement
  • SVGStylable
  • SVGTests.hasExtension
  • SVGTests.requiredFeatures
  • SyncEventInit
  • ValidateAssertionCallback
  • WebKitDirectoryEntry
  • WebKitDirectoryReader
  • WebKitEntriesCallback
  • WebKitEntry
  • WebKitErrorCallback
  • WebKitFileCallback
  • WebKitFileEntry
  • WebKitFileSystem

This was referenced Jul 26, 2018
Closed
Closed
@mhegazy mhegazy merged commit 59e6109 into master Jul 31, 2018
@mhegazy mhegazy deleted the portGeneratedLibFiles branch July 31, 2018 17:20
@weswigham
Copy link
Copy Markdown
Member

weswigham commented Aug 1, 2018 •
edited
Loading

@mhegazy I think removing Element.outerHTML seems particularly breaky from glossing over some of our tests. It also appears to be supported in all (somewhat recent) browsers according to MDN, so why'd it get removed?

This was referenced Aug 1, 2018
Closed
Merged
Merged
Merged
Merged
Merged
Closed
@ghost
Copy link
Copy Markdown

ghost commented Aug 1, 2018

Same for innerHTML (#26123)

This was referenced Aug 1, 2018
Closed
Merged
Merged
Closed
Merged
Closed
Closed
Merged
Closed
Merged
Closed
Merged
Merged
This was referenced Aug 2, 2018
Merged
Merged
@mhegazy
Copy link
Copy Markdown
Contributor Author

mhegazy commented Aug 2, 2018

innerHTML, outerHTML, style should all be back.

Fixes included in #26161 and #26171

@casamia918
Copy link
Copy Markdown

casamia918 commented Aug 3, 2018

#26038 is still not fixed.

ERROR in [at-loader] ./node_modules/@types/webvr-api/index.d.ts:140:3
TS2717: Subsequent property declarations must have the same type. Property 'leftBounds' must be of type 'Float32Array | number[]', but here has type 'number[]'.

This error message is torturing me..

@chlab
Copy link
Copy Markdown

chlab commented Dec 19, 2018

I can't find any context for why MediaQueryListListener was removed. I have code that uses this interface. Could someone shed some light on this?

This was referenced Jul 8, 2023
Closed
Closed
Closed
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@mhegazy mhegazy

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mhegazy @weswigham @casamia918 @chlab