25840 - Add a more meaningful error message to the case when calling a public static method on an instance#25922
Merged
Conversation
sandersn
requested changes
Jul 25, 2018
c629c8b to
ee1a506
Compare
Contributor
|
@sandersn can you take another look please. |
sandersn
requested changes
Jul 30, 2018
Member
sandersn
left a comment
There was a problem hiding this comment.
See my previous comment about a change to typeHasStaticPropertyName.
… static method on an instance
… feature/25840-add-a-more-meaningful-error-message-to-the-case-when-calling-a-public-static-method-on-an-instance
ee1a506 to
88b2f6a
Compare
e20b0c3 to
0e06a95
Compare
Member
|
@sandersn can you review the recent commit? |
sandersn
approved these changes
Aug 6, 2018
Member
|
Thanks for the PR @a-tarasyuk! This is a nice contribution to our improved error messages effort. |
Contributor
Author
|
@sandersn Thank you very much for your help! 👍 :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25840