Class declarations should be block scoped.#2588
Merged
Merged
Conversation
added 2 commits
April 1, 2015 17:20
Member
There was a problem hiding this comment.
Turn this into a TODO.
Also, for future reference, I am more in favor of ClassyDeclaration over ClassLikeDeclaration.
Contributor
|
The __extends change should be discussed in the design meeting. so please keep this separate. other than that the change looks good to me. |
8ab8738 to
d048d7d
Compare
CyrusNajmabadi
added a commit
that referenced
this pull request
Apr 2, 2015
Class declarations should be block scoped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2578
Fixes #2579