Report a semantic error for an arrow function with a "this" parameter.#25863
Merged
Conversation
ajafff
reviewed
Jul 23, 2018
|
|
||
|
|
||
| //// [thisTypeInFunctionsNegative.js] | ||
| // @target es6 |
Contributor
There was a problem hiding this comment.
This seems to have no effect. Otherwise the __extends helper wouldn't be emitted.
Contributor
Author
There was a problem hiding this comment.
Good catch. I assumed this was working because I didn't get an error about Promise not being defined, but there may be a different reason that error doesn't occur in the context of the test suite. It looks like I messed up the syntax. Fixed.
a0be704 to
f72193e
Compare
DanielRosenwasser
approved these changes
Jul 24, 2018
Member
DanielRosenwasser
left a comment
There was a problem hiding this comment.
Looks great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9744.