Refactor and improve caching in getTypeOfSymbol callees#25842
Merged
Conversation
1. Always cache calls to getTypeOfSymbol, even in the error case. 2. JS expando types are now cached on the original symbol as well as the cloned symbol. Previously they were only cached on the cloned symbol. 3. Large callees of getTypeOfSymbol (variable/param/property, func/class/enum/module, and accessors) now handle only caching and delegate to -Worker functions whose return values are cached unconditionally (unlike previously).
Previously, successfully obtaining a type from a js special property declaration would forget to pop the circularity detection stack and check its value.
Member
Author
|
Note: Turning on 'Ignore whitespace' is practically a requirement for reading this review. |
ghost
approved these changes
Jul 20, 2018
weswigham
approved these changes
Jul 31, 2018
RyanCavanaugh
approved these changes
Jul 31, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
unconditionally (unlike previously). This makes the code in the -Worker functions easier to write and reason about.