Watch subdirectories in project root instead of watching project root…#25811
Merged
Conversation
… so as to avoid watching excluded directories that are not part of config file Fixes #25629 and microsoft/vscode#51139
15abb90 to
4ee3f2b
Compare
Member
Author
|
@mhegazy can you please review this. @dbaeumer reported this helped in microsoft/vscode#51139 (comment) |
mhegazy
approved these changes
Jul 31, 2018
|
Will this fix not make it in to 3.0.2 ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25629 and microsoft/vscode#51139
Instead of watching projectRoot, watch the subdirectory in it so as to ensure we arent watching the folders in projectRoot that are excluded and arent part of module resolution failed lookup locations.