Skip to content

Add preliminary support for editing JavaScript files using the TS Language Service.#2571

Merged
CyrusNajmabadi merged 22 commits into
masterfrom
JSLS
Apr 2, 2015
Merged

Add preliminary support for editing JavaScript files using the TS Language Service.#2571
CyrusNajmabadi merged 22 commits into
masterfrom
JSLS

Conversation

@CyrusNajmabadi
Copy link
Copy Markdown
Contributor

@CyrusNajmabadi CyrusNajmabadi commented Apr 1, 2015

This includes:

  1. warnings when you use TypeScript specific language constructs in a .js file.
  2. Completion lists on that include all identifiers we know about when you're in a .js file.

@CyrusNajmabadi
Add specialized semantic diagnostics for JavaScript files.
4a34604
@CyrusNajmabadi
Add tests for javascript semantic dianostics.
e650e8a
@CyrusNajmabadi
Add additional tests.
1eca182
@CyrusNajmabadi
Add additional tests.
c698465
@CyrusNajmabadi
Clean up getCompletions code.
e14b745
@CyrusNajmabadi
Further simplification
c030b83
@CyrusNajmabadi
Treat .js files as javascript in the LS.
1b06677
@CyrusNajmabadi
Merge branch 'master' into javascriptLanguageservice
40f0de8 
Conflicts:
	src/services/services.ts
@CyrusNajmabadi
Merge branch 'completionEntryDetails' into javascriptLanguageservice
f583fd4 
Conflicts:
	src/services/services.ts
@CyrusNajmabadi
back to tsjs
d3e9ed1
@CyrusNajmabadi
Merge branch 'findReferences' into javascriptLanguageservice
c2c44b3
@CyrusNajmabadi
Back to .js
273c3a9
@CyrusNajmabadi
Merge branch 'master' into javascriptLanguageservice
ff2609f
@CyrusNajmabadi
Merge branch 'master' into JSLS
552d82b 
Conflicts:
	src/services/services.ts
@CyrusNajmabadi
Merge branch 'master' into JSLS
1385d9b 
Conflicts:
	src/services/services.ts
@CyrusNajmabadi
Remove unnecessary code.
72d23c7
DanielRosenwasser
DanielRosenwasser reviewed Apr 1, 2015
View reviewed changes
Comment thread src/harness/fourslash.ts Outdated
Copy link
Copy Markdown
Member

@DanielRosenwasser DanielRosenwasser Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename testOptMetadataNames to metadataOptionNames.

DanielRosenwasser
DanielRosenwasser reviewed Apr 1, 2015
View reviewed changes
Comment thread src/server/protocol.d.ts
Copy link
Copy Markdown
Member

@DanielRosenwasser DanielRosenwasser Apr 1, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move asterisks back a space for consistency

CyrusNajmabadi added a commit that referenced this pull request Apr 2, 2015
@CyrusNajmabadi
Merge pull request #2571 from Microsoft/JSLS
45412f6 
Add preliminary support for editing JavaScript files using the TS Language Service.
@CyrusNajmabadi CyrusNajmabadi merged commit 45412f6 into master Apr 2, 2015
@CyrusNajmabadi CyrusNajmabadi deleted the JSLS branch April 2, 2015 22:33
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@CyrusNajmabadi @yuit @DanielRosenwasser @mhegazy @msftclas