mapTextChangesToCodeEditsUsingScriptInfo: Handle tsconfig.json text change#25586
Merged
3 commits merged intoJul 12, 2018
Merged
mapTextChangesToCodeEditsUsingScriptInfo: Handle tsconfig.json text change#255863 commits merged into
3 commits merged into
Conversation
…multiple projects exist
Author
|
Latest commit fixes #24857. The problem was that when |
| export const enum ScriptInfoOrConfigKind { ScriptInfo, Config } | ||
| /* @internal */ | ||
| export type ScriptInfoOrConfig = | ||
| | { readonly kind: ScriptInfoOrConfigKind.ScriptInfo, readonly info: ScriptInfo } |
Member
There was a problem hiding this comment.
Why do you need this? You can look determine if its sourceFile(config) by just checking
function isConfigFile(config: SourceFile | ScriptInfo) : config is SourceFile {
(config as SourceFile).kind !== undefined;
}
sheetalkamat
approved these changes
Jul 12, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Noticed while looking at #24857 -- there's no
ScriptInfofor atsconfig.jsonfile so we have to use a union.